(G004) remove deprecated ModelicaSystem rewrite_set_functions() - #452
Merged
adeas31 merged 2 commits intoAug 21, 2026
Conversation
syntron
force-pushed
the
G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2
branch
from
May 11, 2026 18:53
a9206d3 to
e2f18f2
Compare
syntron
force-pushed
the
G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2
branch
2 times, most recently
from
June 30, 2026 19:50
17e049e to
2b5c2db
Compare
syntron
force-pushed
the
G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2
branch
3 times, most recently
from
August 14, 2026 17:04
8610abe to
e72bfee
Compare
Member
|
Please rebase. |
[ModelicaSystemABC] remove code for (depreciated) arguments in set*() methods * define code in the compatibility layer in class ModelicaSystem [test_ModelicaSystem(OMC)] update tests * for new version: remove usage of old definition * for compatibility version: test old definition
syntron
force-pushed
the
G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2
branch
from
August 18, 2026 19:44
e72bfee to
d5c4810
Compare
Contributor
Author
@adeas31 done |
adeas31
approved these changes
Aug 21, 2026
syntron
deleted the
G004-remove_deprecated-ModelicaSystem_rewrite_set_functions2
branch
August 21, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ModelicaSystemABC] remove code for (depreciated) arguments in set*() methods
[test_ModelicaSystem(OMC)] update tests