Repository navigation
Web page: one panel, the UART terminal as a collapsible section (1.16.2) - #106
Merged
Merged
Conversation
PR Summary by QodoUnify the web console and make the UART terminal collapsible
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105.
The
-wpage had two panels of different widths: "Power console" (760 px) and "UART terminal" (1100 px). Now it is one panel:<button>,aria-expanded) opens and closes the terminal inside the panel; closed by default;/statusterminalsstays 0);localStorage(wrapped in try/catch: without storage it just starts closed);make WEBTERM=0: no bar, the page as before but one width.The Android terminal screen is unchanged. Screenshots in the three READMEs retaken on 1.16.2 (closed and opened), README text updated.
Before: two panels, 760 px and 1100 px, the terminal always open and connected.
After:
Checked locally (
compot/cross, headless Chromium via puppeteer against a pty): build without warnings with default,WEBTERM=0andUSB=0;tests/test_vectis.pypasses for the default andWEBTERM=0builds (new check: one panel, the section starts closed); in the browser: closed on load, opens and connects on click, typing works, the lamp lights on output while closed and clears on opening, the choice survives a reload, narrow (400 px) layout is one column, no JS errors.