focus: the sweep's verdict names the gain by the name on its box

[widgetii]

v0.19.0 labelled the first gain Scale and reworded the live grid's counter warning to match, but the sweep's own "Cannot say" verdict still said "lower the first gain" — the phrase the labels were added to retire. Seen on the lab 85H50AI the first time a sweep ran over the pinned star chart. It now says the same sentence as the designer's warning. The UI check that pinned the old phrase now pins the new one; full loop clean.

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Name Scale explicitly in pinned-sweep saturation verdict

🐞 Bug fix 🧪 Tests 🕐 Less than 10 minutes

AI Description

• Names the Scale control explicitly in pinned-sweep saturation guidance.
• Aligns source and distribution bundles with the live-grid warning.
• Tightens the UI check to require the corrected control name.

Diagram

graph TD
  A["Pinned sweep"] -->|pinned result| B["Sweep verdict"] -->|names Scale| C["Status message"] -->|asserted by| D["UI check"]

Loading

High-Level Assessment

The direct copy correction in both source and distribution output, paired with a more specific UI assertion, is appropriate for this narrowly scoped consistency bug. Extracting shared warning text was considered but would add unnecessary refactoring because the sweep and live-grid sentences differ by context.

Files changed (3) +7 / -7

Bug fix (2) +6 / -6

editor.jsCorrect bundled pinned-sweep guidance +3/-3

Correct bundled pinned-sweep guidance

• Changes the distributed editor’s Cannot say verdict to instruct operators to lower Scale, identifying it as the first gain. This keeps the shipped bundle consistent with the source and live-grid warning.

dist/editor.js

editor.jsName Scale in pinned-sweep saturation verdict +3/-3

Name Scale in pinned-sweep saturation verdict

• Replaces the generic instruction to lower the first gain with explicit Scale terminology. Operators can now match the verdict directly to the label on the control.

src/editor.js

Tests (1) +1 / -1

ui-check.htmlAssert the corrected Scale guidance +1/-1

Assert the corrected Scale guidance

• Updates the pinned-peak UI check to require the rendered verdict to contain “Lower Scale” rather than the generic “first gain” phrase.

tests/ui-check.html