Repository navigation
feat: debug page password in Network, web port always 8085, black snapshot cells told (2.24.0) - #277
Conversation
…085, black snapshot cells told (2.24.0) - Network: Web page password (empty: open). Every request to port 8085 needs it (HTTP Basic, any user name), from the local network and the tunnel alike; kept sealed; a stored one that cannot be read keeps the pages locked. The server reads it itself, so it holds from the first request. - The Web port field is gone: Decoder always gives camex 8085 (DebugServer.PORT). - Snapshot: a live cell whose copy comes out black (a hardware video plane, two of four cells on the SberBox) says so instead of showing black. - tests/e2e.sh: the debug page through the tunnel asks for the password (14 checks).
PR Summary by QodoProtect the debug page, fix its tunnel port, and explain black snapshots
AI Description
Diagram
High-Level Assessment
Files changed (15)
|
Code Review by Qodo
1. Web passwords stay plaintext on old boxes
|
… costs a second; a black copy told neutrally (Qodo on #277)
|
Qodo findings, each decided:
Rechecked: |
Three changes asked for together.
1. Password for the debug page (port 8085). Network gets a last field, Web page password (empty by default: the pages stay open, as before). When set, every request to port 8085 (
/,/stats.json,/snapshot.jpg,/log,/report.txt, ...) needs it: HTTP Basic, any user name (curl -u :<password>), answered401withWWW-Authenticate: Basic realm="OpenIPC Decoder", charset="UTF-8"otherwise. The same from the local network and through the camex tunnel. The password is kept sealed withCredentialStore, like the camera URLs and the psk; the server reads it itself (WebPassword), so it holds from the first request, even before an activity starts; a stored one that cannot be opened keeps the pages locked until it is entered again. Compared in constant time (SHA-256 of both sides).2. Web port always 8085. The Web port field of camex 3.19.0 is no longer shown: Decoder always passes
--web-port 8085(DebugServer.PORT), so nginx on the server finds the page. This needs a camex server 3.19.0 or later, by decision: older servers are not supported.3. Black cells in the snapshot. On the SberBox (Amlogic, MesonHwc2) the screen shows two of four cells on hardware video planes (
composition=DEVICEindumpsys SurfaceFlinger), which PixelCopy andscreencapread as black (99.5 % dark pixels, against 0.1-18 % for the other cells, at night too); which two is up to the device, the TV shows all four. A live cell whose copy comes out at least 98 % dark now says video on screen, this device does not let it be copied instead of being plain black, with or without labels (the page draws its own labels and cannot know).Version 2.24.0 (versionCode 57), CHANGELOG, README (en/ru/zh-CN),
docs/security.md,docs/debug.md,docs/testing.md.Checked locally in
compot/android:2026.10:testDebugUnitTest406/406 (new: Basic parsing, any user name, wrong and missing password, locked when unreadable, base64; black-copy threshold),lintDebugno new findings.tests/e2e.sh14/14 on API 34 and API 21 with a new check: the Linux client of the tunnel gets401without a password,401with a wrong one and200with the right one from the box's tunnel address; the tunnel connects with--web-port 8085to a 3.19.0 hub. The snapshot note is checked on the SberBox after the release (a debug build would need a reinstall there, which drops its tunnel settings).