Skip to content

build: camex 3.19.0 in Network (2.23.0) - #275

Merged
compot-dev merged 1 commit into
v2from
build/camex-3.19.0
Nov 17, 2026
Merged

compot-dev merged 1 commit into
v2from
build/camex-3.19.0

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Moves bundles/camex from the 3.18.0 release (6220a01) to the 3.19.0 release (4c2626f, OpenIPC/camex#176).

What Decoder gets from the library:

Version 2.23.0 (versionCode 56), CHANGELOG section, README (en/ru/zh-CN) Network paragraph updated.

Checked locally in compot/android:2026.10: testDebugUnitTest 400/400, lintDebug no new findings, assembleDebug with libcamex.so for arm64-v8a and armeabi-v7a; tests/e2e.sh 13/13 on API 34 and API 21 (camera through the tunnel, Auto over TCP, tunnel restart with Network → Save).

Known upstream: OpenIPC/camex#173 (Android 5.0, after stop() and start() in one process app sockets sometimes leave from eth0) stays open; the e2e restart check on API 21 passed.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Upgrade camex to 3.19.0 for Network options and route limits

✨ Enhancement ⚙️ Configuration changes 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Upgrade the bundled camex tunnel to 3.19.0, adding optional server timeout and web port settings.
• Reject server-provided routes and subnets wider than /8 to limit tunnel traffic.
• Release Decoder 2.23.0 and document the Network changes in three languages.
Diagram

graph TD
  UI["Network dialog"] --> API["CamexTunnel fields"] --> LIB["camex 3.19.0"] --> SERVER["camex server"] --> CAM["Cameras"]
Loading
High-Level Assessment

Keep the library-driven Network dialog and upgrade the bundled release. Adding app-specific controls or route filtering would duplicate behavior owned by camex; review the upstream submodule changes to verify the documented guarantees.

Files changed (6) +15 / -6

Documentation (4) +12 / -3
CHANGELOG.mdDocument the 2.23.0 Network release +9/-0

Document the 2.23.0 Network release

• Adds release notes for the optional timeout and web port settings and the /8 route limit.

CHANGELOG.md

README.mdUpdate the English Network overview +1/-1

Update the English Network overview

• Describes camex 3.19.0, the new settings, server compatibility for web port, and the route limit.

README.md

README.ru.mdUpdate the Russian Network overview +1/-1

Update the Russian Network overview

• Documents the upgraded tunnel, new settings, and route limit in Russian.

README.ru.md

README.zh-CN.mdUpdate the Chinese Network overview +1/-1

Update the Chinese Network overview

• Documents the upgraded tunnel, new settings, and route limit in Simplified Chinese.

README.zh-CN.md

Other (2) +3 / -3
build.gradleSet Decoder version to 2.23.0 +2/-2

Set Decoder version to 2.23.0

• Increments versionCode from 55 to 56 and versionName from 2.22.0 to 2.23.0.

android/app/build.gradle

camexAdvance the camex submodule to 3.19.0 +1/-1

Advance the camex submodule to 3.19.0

• Moves the submodule from commit 6220a01 to 4c2626f. Decoder’s existing field-driven Network dialog can consume the release’s optional settings without app source changes; the release also supplies the documented route limit.

bundles/camex

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (1) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Android 5 restart fix checked only on emulators 📎 Requirement gap ☼ Reliability
Description
The PR moves the bundles/camex pointer to 4c2626f, which the description says carries the 3.19.0
changes, but the description's only Android 5.0 evidence is the tests/e2e.sh restart check on an
API 21 emulator. The description also says upstream camex#173 (sockets leaking from eth0 after
stop() and start() in one process) stays open, and it names no real Android 5 device and no separate
camex-app same-process run. The investigation the rule asks for, including whether retained routing
or source-address state after VPN teardown matters, is therefore not recorded anywhere in the PR.
Code

bundles/camex[1]

+Subproject commit 4c2626f9b1df6701664bcd8d27ac3081b38ebfb2
Evidence
The PR description reports emulator-only checks (compot/android:2026.10, tests/e2e.sh on API 21
and API 34) and states that the upstream Android 5.0 restart issue remains open. Nothing in the diff
or description records a real Android 5 device run, a camex-app same-process scenario, or an
examination of post-teardown network state, which are the failure criteria of this rule.

Investigate Android 5.0 VPN restart behavior beyond the emulator
bundles/camex: bundles/camex

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
Issue description: The PR bumps the camex submodule to 3.19.0 while the Android 5.0 Stop→Start source-address issue (camex#173) remains open, and the only Android 5.0 verification is an API 21 emulator e2e run. Fix Focus Areas: - bundles/camex[1-1]. Recommended Fix: Run the Stop→Start scenario in the camex Android app without restarting its process and on a real Android 5 device; check whether tunneled TCP/UDP from new app connections uses the tunnel address or eth0 (10.0.2.15); record the results, including whether retained routing or source-address state after VPN teardown contributes, in the PR description or a linked issue comment.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev

Copy link
Copy Markdown
Collaborator Author

Qodo: "Android 5 restart fix checked only on emulators" — not changed here. This PR does not claim a fix for OpenIPC/camex#173: it only moves the submodule to the 3.19.0 release. #173 is open in camex and is investigated there (real Android 5 device, same-process Stop → Start, source address after teardown); Decoder takes the fix with a later camex release. The API 21 e2e result is recorded as what it is: the restart check passed on the emulator.

@compot-dev
compot-dev merged commit b6b2a7d into v2 Nov 17, 2026
7 checks passed
@compot-dev
compot-dev deleted the build/camex-3.19.0 branch November 17, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant