Repository navigation
Windows build without warnings (4.0.2) - #186
Merged
Merged
Conversation
…ent off Windows The log line of a bad TCP frame length printed size_t values with %zu, which the Windows build's printf format check rejects (and could log wrong numbers there): printed as unsigned long now. tun_persistent is used only outside Windows and is no longer defined in the Windows build. Found by docker/test-windows.sh (#184). Version 4.0.2.
PR Summary by QodoEliminate Windows build warnings and release version 4.0.2
AI Description
Merge Risk
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows build of 4.0.1 warned in two places;
docker/test-windows.sh(#184) showed them.src/net.c: the log line of a bad TCP frame length printedsize_tvalues with%zu. The Windows build's printf format check rejects it ("unknown conversion type character 'z'") and the arguments after it could be logged wrong. They are now printed asunsigned long, as elsewhere in the code.src/tun.c:tun_persistentis used only outside Windows; it is no longer defined in the Windows build ("defined but not used").Version 4.0.2, CHANGELOG entry added.
Checked locally:
docker/test-windows.sh(x86_64 and i686, no warnings,--version/--helpunder Wine), the native build withmake test, and the static musl builds for x86_64, aarch64, arm and mipsel — no warnings.