Skip to content

test-windows.sh: OUT with spaces; --help checked by its exit status - #185

Merged
compot-dev merged 1 commit into
masterfrom
windows-check-review
Nov 18, 2026
Merged

compot-dev merged 1 commit into
masterfrom
windows-check-review

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Follow-up to the Qodo review of #184.

  • OUT with a space: the optional mount is passed as positional parameters, "$@", not as one unquoted string.
  • --help under Wine: the output is captured and a nonzero exit fails the check; before, the status was grep's.

Test-only, no-release. Checked: OUT="…/out dir" docker/test-windows.sh passes for both architectures and leaves both .exe files there; shellcheck is clean.

@compot-dev compot-dev added the no-release Changes the build or the code without changing the binaries: no new version, no release label Nov 18, 2026
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Fix Windows smoke test output paths and Wine --help failure detection

🐞 Bug fix 🧪 Tests 🕐 Less than 10 minutes

Grey Divider

AI Description

• Preserve spaces in optional output paths so both Windows executables can be saved reliably.
• Fail the Wine smoke test when --help exits unsuccessfully, independently of its output.
Merge Risk 🟢 Low

Blast radius 🟢 Low 💥 0 capabilities

  • No production behavior changes identified.
Behavioral complexity 🟢 Low 🧩 Assessed behavior

  • No production behavior changes identified.
Potential damage 🟢 Low 🩹 Assessed behavior

  • No production behavior changes identified.
Assessed commit 8036200 > Snapshot assessment: the current PR revision could not be verified.
Diagram

graph TD
  A["Windows test script"] --> B{"OUT set?"}
  B -->|mount output path| C["Docker run"] --> D["Build both arches"] --> E{"Wine help succeeds?"} -->|yes| F{"Usage present?"} -->|yes| H["Pass smoke"]
  B -->|no mount| C
  E -->|no| G["Fail smoke"]
  F -->|no| G
Loading
High-Level Assessment

Keep the localized shell changes. Positional parameters preserve the optional mount as separate arguments without introducing a dependency, while capturing --help output makes its exit status and content independently testable.

Files changed (1) +7 / -6

Bug fix (1) +7 / -6
test-windows.shHandle spaced output paths and check Wine --help status +7/-6

Handle spaced output paths and check Wine --help status

• Passes the optional OUT mount through quoted positional parameters so paths containing spaces remain one Docker argument. Captures Wine --help output, fails on a nonzero exit, then separately checks for usage text.

docker/test-windows.sh

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@compot-dev
compot-dev merged commit 139520a into master Nov 18, 2026
18 of 19 checks passed
@compot-dev
compot-dev deleted the windows-check-review branch November 18, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Changes the build or the code without changing the binaries: no new version, no release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant