Repository navigation
Throughput test: fail when the netem delay is missing - #182
Conversation
The container entrypoint ignored a failed 'tc qdisc add', so the test could pass on a link without the delay it is meant to exercise. Now the container exits if netem cannot be added, and the test checks that the round trip through the tunnel is at least the two one-way delays.
PR Summary by QodoFail throughput tests when the netem delay is missing
AI Description
Merge Risk
|
Code Review by Qodo
1.
|
…eads it (#182) - test-e2e-throughput.sh: the round trip comes from a ping retried until the server answers (Qodo): the address appears before the session, and a first ping without a reply failed the delay check. - test-e2e-nginx-map.sh: the 2 MB upload went to python's http.server, which answers 501 at once without reading the body; nginx, still sending it, then took the device for offline (503), now and then (CI on 3916d2f). The device's server (web.py) reads a POST to its end and answers with the byte count; the check wants all 2 MB and 200.
|
Handled in 40ec1e8:
Also in 40ec1e8: the CI failure on 3916d2f was Rerun locally in Docker: throughput passes (round trip 60.4 ms); nginx-map passes 3 times in a row. /review |
Follow-up to Qodo's finding on #181 ("The throughput test can pass without delay").
tc qdisc add: the container exits, and the test fails.DELAY_MS.Tested locally in Docker:
DELAY_MS=100but only 30 ms is applied, the new check fails.Test-only change, no release.