Repository navigation
hi3516dv100_lite_anxinshi-asrih698t: the lens travel measured end to end, and the old values corrected - #252
Merged
Merged
Conversation
…end, and the old values corrected lensZoomSteps 3320 and lensFocusSteps 3000 were longer than the lens: every move to the far end of either drove its motor into the stop, and the clicking that went with it. Measured on a dome of this model with majestic-af's tools/clickguard listening for the stops: zoom 2640 microsteps from the tele stop, focus 1300 from the near stop. The limits are 2580 and 1240, 60 short of the far stops; majestic-af keeps 100 clear of the home ones. muxes.sh corrects the exact pair the earlier profile wrote, on the next boot, and leaves any other value alone.
widgetii
requested review from
cronyx,
flyrouter and
viktorxda
as code owners
November 17, 2026 12:55
PR Summary by QodoCorrect ASRIH698T lens travel limits and migrate old settings
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dome's lens travel, measured end to end on the lab HI3516D_N81820 dome (the OpenIPC/firmware#2385 model). Slow jogs ran into each stop under majestic-af's
tools/clickguard, which listens through a second camera's microphone and stops the test on the first click:The configured travel overshot both far stops, so a full move to either far end drove the motor into its stop.
This sets
lensZoomSteps: 2580andlensFocusSteps: 1240, 60 short of the far stops. With these limits, full-speed moves into all four limits were silent on the lab dome. majestic-af (OpenIPC/firmware#2883) keeps 100 microsteps clear of the home stops.muxes.shcorrects the exact pair the earlier profile wrote (3320/3000) on the next boot and leaves any other value alone. The lower limits are safe with the current majestic-af too: they only keep the lens further from its stops.