Repository navigation
📦🔥:read a lazy expectation without caching it - #95
openinf-commit-queue[bot] merged 1 commit into
Conversation
getExpectation wrote a lazy expectation's result back over the function. For a frozen validator that write threw a TypeError, and for any other it pinned the message to whatever the expectation said the first time. It now calls the function each time and writes nothing. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthrough
ChangesLazy expectation evaluation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Lazy expectations are evaluated on each read without changing the validator, and the added test covers changing results for a frozen guard. No actionable merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review Generated by Claude Code |
✅ Action performedReview finished.
|
Requested by DerekNonGeneric
Before:
getExpectationwrote a lazy expectation's result back over the function. That write threw aTypeErrorfor a frozen validator. For any other validator, the message stayed at whatever the expectation said the first time it was read.After: the function is called on every read and the validator is never modified.
How: the result goes into a local variable instead of being assigned back. A new test freezes a validator and changes the value its expectation describes. It fails on main and passes here.
Summary by CodeRabbit