Repository navigation
📖🔧:make the API reference match the behavior - #93
Conversation
getAllKeys was documented as returning own keys while it walks the whole prototype chain. The has example used an undefined variable, called create with one argument where two were required, and said an inherited key was missing. isNamed described itself as an Array check. isNumber and has pointed at functions that do not exist. create now takes its properties as optional, as documented, and getFunctionName accepts any function rather than only one without parameters, and reads the name of an async or generator function from its source. isTypedArray lists Float16Array, and four util-types descriptions get their articles and type names right. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (14)
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe pull request updates API documentation across four packages. It also makes the ChangesAPI and object helper updates
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The documentation and helper API updates present no identified merge-blocking risk. Merge after normal checks pass. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 13 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Requested by DerekNonGeneric
Before: the docs for several functions disagreed with what the code does.
getAllKeyswas documented as returning own keys, but it walks the whole prototype chain.hasexample used an undefined variable and calledcreatewith one argument, although two were required. It also claimed an inherited key was missing, buthasusesin.isNameddescribed itself as an Array check.isNumberandhaslinked to functions that don't exist.getFunctionNamerejected any function that takes parameters, and could not read the name of an async or generator function from its source.After: each description says what the function does.
create(proto)type-checks, andgetFunctionNameaccepts any function.isTypedArraylistsFloat16Array, and four util-types descriptions use the right article or type name.How: most of this is doc-comment edits. The two code changes are signature fixes, each with a test that failed to compile on main:
create's properties parameter is now optional.getFunctionNametakesAnyFunction, and its regex now also matchesasync functionandfunction*. The regex is anchored and avoids nested quantifiers.Summary by CodeRabbit
createnow allows the properties argument to be omitted.$, and accepts functions with parameters.Object.prototypekeys.Float16Arraysupport in the documented typed-array types. Also corrected return descriptions and examples.