Repository navigation
🧪🔧:pass the validateOneOf test in any locale - #116
Merged
openinf-commit-queue[bot] merged 1 commit intoOct 9, 2026
Merged
Conversation
The test spelled the expected message with curly quotes, but curlyQuote only uses them when LC_ALL, LC_CTYPE or LANG names UTF-8. Without one, as in a bare container, pnpm test failed on a message that was right. The expectation now uses curlyQuote too, as the util-errors tests already do. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
openinf-commit-queue
Bot
deleted the
claude/project-thread-xj2fx1-locale-test
branch
October 9, 2026 00:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by DerekNonGeneric
Before:
pnpm testfailed in@openinf/utilon any machine without a UTF-8 locale (noLC_ALL,LC_CTYPEorLANGnaming UTF-8, as in a bare container). The validateOneOf test spelled the expected message with curly quotes, butcurlyQuoteuses straight quotes there, so a correct message was reported as wrong.After: the test passes with or without a UTF-8 locale.
How: the expected message is built with
curlyQuote, the way the util-errors tests already build theirs. Test-only, so there's no changeset.Summary by CodeRabbit