Repository navigation
📦🔧:keep deep merges within their own graphs - #110
DerekNonGeneric wants to merge 1 commit into
Conversation
Limit recursive merging to the target's own properties. Track active source-target pairs rather than skipping later source arguments, and isolate copy caches when one source fills distinct existing targets. Share the plain-object classifier with array copying so foreign-realm objects are copied consistently. Add graph and isolation regressions. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Codex:gpt-6-astra PR-URL: #105 Fixes: #100
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (8)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe changes add shared plain-object detection and use it in array copying and object guards. They also update deep-merge handling for repeated sources, inherited target properties, and cyclic object graphs, with tests and patch release entries. ChangesObject graph copying and merging
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No identified regression requires a fix before merge; normal checks remain appropriate. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review Generated by Claude Code |
✅ Action performedReview finished.
|
Requested by DerekNonGeneric · project thread
Review only. Do not merge. This replays the already-merged #105 (commit 682eaae against its parent) so CodeRabbit can review it, because it hit its rate limit when #105 was open and it refuses to review closed PRs. Findings will be fixed in a separate PR against main, and this PR will be closed.
Generated by Claude Code
Summary by CodeRabbit