Repository navigation
馃摝馃敡锛歳ecognize comments in generator syntax - #108
Merged
Merged
Conversation
Treat line comments and their terminators as source gaps when checking generator and async-generator function shapes. This matches valid source preserved by Function.prototype.toString. Add regressions for both generator kinds. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Codex:gpt-6-astra Fixes: #107
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 54 minutes. View limit detailsLimit details: You鈥檝e used all 4 included reviews currently available. Your 36 included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. Review configuration: 鈿欙笍 Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 馃搾 Files selected for processing (4)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generator shape matching accepted whitespace and block comments between the
functionkeyword and*, but rejected valid functions whose retained sourcecontains a line comment there.
This treats line comments plus each ECMAScript line terminator as source gaps
and adds generator and async-generator regressions.
Fixes #107.