Repository navigation
📦🔧:keep email validation linear and precise - #101
Conversation
Replace the backtracking pattern with bounded scans while preserving the existing basic syntax. Narrow to a branded Email type so a failed check does not incorrectly exclude other strings. Cover accepted syntax, whitespace, long invalid inputs, and narrowing. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Codex:gpt-6-astra
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthrough
ChangesEmail validation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The validation change is mergeable after normal checks; no concrete compatibility regression was found. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
The commit queue did not land this. See https://github.com/OpenINF/sdk/actions/runs/36962272189 — the label has been taken back off, so re-applying it is a deliberate second try. |
The email guard's backtracking pattern took quadratic time on invalid dotted
domains and could block the event loop. Its
value is stringreturn type alsomade TypeScript exclude every string after a failed syntax check.
This replaces the pattern with linear scans while preserving its accepted
syntax, introduces a branded
Emailrefinement, and adds compatibility,narrowing, whitespace, and adversarial-input regressions.
This is a security-sensitive validation fix, so no public vulnerability issue
was opened.
Summary by CodeRabbit
@symbols, and domains with empty sections around a dot.Emailtype.