Streamline time slider loading#327
Conversation
| let ohmlayer; | ||
| map.eachLayer(function (layer) { // there's only 1 or 0 time layers at a time, so this works | ||
| if (historicalLayerKeys.indexOf(layer.options.layerId) !== -1) ohmlayer = layer; | ||
| if (layer instanceof L.OSM.OHM) ohmlayer = layer; |
There was a problem hiding this comment.
This assumes every instance of L.OSM.OHM is time-enabled. That’s currently true, but if we ever choose to publish an all-time cumulative style that isn’t filtered by date, then we’ll need to push this decision down to each instance of L.OSM.OHM via a new property in layers.yml.
1ec5
force-pushed
the
1ec5-timeslider-control-subclass
branch
from
ba31d08 to
41d4dee
Compare
Restored normal page loading to be synchronous. Load the time slider synchronously as part of page loading. Fixed a bad merge in directions.js. Removed inconsistent support for date parameters as query parameters, leaving only support for date parameters as hash parameters.
1ec5
force-pushed
the
1ec5-timeslider-control-subclass
branch
from
41d4dee to
f61a503
Compare
| @@ -85,16 +84,5 @@ function addOpenHistoricalMapTimeSlider (map, params, onreadycallback) { | |||
| slideroptions.vectorLayer = ohmlayer; | |||
There was a problem hiding this comment.
Do you want to move the if (getHistoryLayerIfShowing()) check in here? So if (ohmlayer)?
If getHistoryLayerIfShowing() returns null, will this get called again by the 'baselayerchange' handler? (I'm just wondering about the source of the race condition.)
There was a problem hiding this comment.
That would avoid an extraneous call. I don’t think it’s the source of the race condition though. That was the polling that I removed below.
|
This was rebased and merged with #433 |
github-project-automation
Bot
moved this to In Production
in OpenHistoricalMap Dev Planning
erictheise
moved this from In Production
to Ready for Staging
in OpenHistoricalMap Dev Planning
erictheise
moved this from Ready for Staging
to On Staging
in OpenHistoricalMap Dev Planning
3 participants
This PR restores normal page loading to be synchronous and loads the time slider synchronously as part of page loading. I’ve also fixed a bad merge in directions.js (which is currently inaccessible). The new streamlined initialization code only supports date parameters as hash parameters (after the
#). I’ve removed support for date parameters as query parameters (after the?), which were only supported on a couple of the pages and are probably rarely used.This also removes a hard-coded list of time-enabled layer IDs, so there are fewer steps to remember when adding a new layer.
Fixes OpenHistoricalMap/issues#1179.