fix(slack): trigger monitor on bot mentions - #492
Conversation
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
|
@AbarnaaSree Thanks for the PR. Did you test it? Do you have a video to show that it works properly? |
|
Yes, I tested the change locally with the Slack channel monitor regression suite:
The tests cover direct bot mentions, named bot mentions, non-bot mentions, similar trigger text, and trigger ordering. The existing I don't have a video at the moment, but the regression tests exercise the Slack mention parsing and trigger behavior directly. I can provide a short recording if needed. |
|
I'm on it! AbarnaaSree can track my progress at all-hands.dev |
|
@VascoSch92 I independently verified the testing claim from @AbarnaaSree above. I checked out the PR head ( I also ran the rest of the repository test suite for regressions: 735 passed. The only failure ( The tests cover the exact behaviors in question: direct Note: this comment was generated by an AI agent (OpenHands) on behalf of the maintainers. |
|
I'm on it! AbarnaaSree can track my progress at all-hands.dev |
|
Handled the PR #492 comment by independently verifying the author's testing claim and replying on the PR. What I did:
No code changes were needed, so nothing was pushed. The HUMAN: section flagged by the automated bot check already contains real content (>20 chars), so that check should pass when it re-runs. |
|
Follow-up: I fixed the PR description formatting so the automated I also re-ran the Slack channel monitor regression suite on the PR head ( No code changes were needed. Note: this comment was generated by an AI agent (OpenHands) on behalf of @AbarnaaSree. |
|
Handled the PR #492 comment. The triggering comment was the previous agent's verification report (no code change requested, no open review threads). I independently re-ran the Slack channel monitor regression suite on the PR head c254c5f (9/9 passed), fixed the PR description's broken markdown (unclosed powershell fence that had swallowed the HUMAN: section required by the automated check), and posted a brief follow-up comment with AI disclosure: #492 (comment). No code changes were needed, so nothing was pushed. |
|
I think we want an human to verify that. |
|
Hi @VascoSch92, I understand that you’d like a human verification. I’ve verified the implementation with the regression tests, but I don’t currently have access to a configured Slack workspace/environment to perform the end-to-end manual test. If there is a recommended test workspace or setup I can use, I’d be happy to verify it manually. |
|
@AbarnaaSree You can create your own workspace in slack, and then use it to test the bot. |
|
Thanks, @VascoSch92. I’ll create a Slack workspace and perform the manual end-to-end test there. I’ll verify that the bot mention triggers the Slack channel monitor as expected and report the results here. |
|
Hi @VascoSch92, I’ve created a Slack workspace, installed the test bot, and added it to a test channel. I’m now setting up the Slack channel monitor for the manual E2E test. However, the repository instructions require the Automation backend url_from_agent and OPENHANDS_AUTOMATION_API_KEY from <RUNTIME_SERVICES>, and these aren’t available in my local environment. Could you point me to the recommended way to access or start the Automation backend for this test? |
Slack app mentions are represented in message text as
<@USER_ID>or<@USER_ID|name>, rather than the literal@openhandstrigger phrase.The Slack channel monitor previously only detected the literal
@openhandstrigger, so messages that directly mentioned the bot were ignored and no conversation was created.Summary
auth.testand use it for trigger matching.@openhandstrigger behavior.Issue Number
Closes #431
How to Test
Run the Slack channel monitor test suite:
HUMAN:
Tested the Slack channel monitor regression suite covering bot mentions, named bot mentions, non-bot mentions, similar trigger text, and trigger ordering.