Repository navigation
Revert #1331 until its agent-comms pair #3607 lands - #1348
Merged
Merged
Conversation
thread_comms.py calls entry.person.present(), which needs RelationshipEntry.person as ThreadView|NoThreadView from agent-comms#3607. On agent-comms main person is ThreadView|None and ThreadView (presentation.py:723) has no present(), so every relationship row raises. The review verdict merged it alone because agent-comms/review is the only required toad check. Reland with #3607. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dS2Kmg1WxNnAc78YHA
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1331. It merged on its review verdict alone (agent-comms/review is the only required check) while its pair agent-comms#3607 is unmerged:
entry.person.present()(thread_comms.py) needsThreadView|NoThreadViewfrom #3607; agent-comms main hasThreadView|Noneand nopresent()(presentation.py:723), so relationship rows raise. Reland together with #3607.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dS2Kmg1WxNnAc78YHA