Repository navigation
Fix two stale Toad tests that failed every hosted suite - #1334
Merged
Merged
Conversation
d1c65d0 unified refusal explanations, so a process that exits during startup is reported as LogAgentFail("ACP session startup failed") (agent_session.py:255), not the process-level detail. The test still asserts the behaviour it exists for: reported, never ready, process gone. Found on #1320's first hosted run (run 40956631782). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 29, 2026 21:25
AgentProcess.start captures a RouteSelection for its transcript root, and RouteSelection owns no route lock; Core publishers alone own route storage and its publication lock. The test flocked a default-route directory that need not exist (FileNotFoundError on a fresh runner, run 40956631782) and its launch_root fixture never published the route it claimed. Child and session retirement remain asserted for cancel, stop and EOF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests on Toad main failed on #1320's first hosted run (run 40956631782), independent of the Neovim work. 2 test files, +4/-29.
tests/app/test_agent_startup_failure.py: waited for "ACP process closed"; since d1c65d0 the conversation showsLogAgentFail("ACP session startup failed")(src/toad/acp/agent_session.py:255). Behaviour checks unchanged.tests/model/test_agent_process_retirement.py: deletedroute_lock_available, itsfcntl/os/active_route_pathimports, the unusedlaunch_rootfixture and the route-lock assertion.AgentProcess.startcaptures aRouteSelectionthat owns no route lock (Core publishers own route storage and its lock), so the probe flocked a directory that need not exist. Child and session retirement stay asserted for cancel, stop and EOF. Ruled obsolete by root (f0d6b4b88f09); no mkdir, no caught FileNotFoundError, no fake lock.🤖 Generated with Claude Code