Repository navigation
Diff the debt ratchet from the PR's merge-base, not GitHub's stale base.sha - #1329
Merged
Merged
Conversation
…se.sha pull_request.base.sha is not refreshed when main moves. toad#1320 at c29eaa1 was diffed from 6d83f98, fifteen main commits behind its real merge-base 4c3c4f3, and charged with a NoneAbsence at screens/main.py:231 and a BroadSwallow at session_navigation.py:319 that main commits 776f7f9 and 961e7ca introduced; #1320 touches neither file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dR85kyFKcc2tQAJLhK
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 29, 2026 18:56
trissim
disabled auto-merge
October 29, 2026 19:14
Author
|
Carried unchanged into #1320 as d036dc5 (cherry-pick of 073c292, identical stable patch-id ea1a2e50a11d7dfd260fcfc6589f3ed2b7093503). #1329 could not go green alone: toad main imports VimInsert, which textual#208 removed, so every toad PR fails collection until #1320's compatible engine lands. Proof the fix works: #1320 run 40938461799, Debt ratchet SUCCESS against the real merge-base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 file, +5/-2. The Debt ratchet now diffs from
git merge-base origin/<base> HEADinstead ofgithub.event.pull_request.base.sha.The bug
GitHub does not refresh
pull_request.base.shawhen the base branch moves. So the ratchet compared PR heads against a stale main and charged them for debt that main itself added later.Witness: toad#1320 (embedded neovim) at c29eaa1
6d83f98ac. The real merge-base is4c3c4f3a0, 15 main commits later.NoneAbsence src/toad/screens/main.py:231, from main commit 776f7f9 "Use content readiness for painted reads…"BroadSwallow src/toad/session_navigation.py:319, from main.git diff 4c3c4f3a0 c29eaa12c --statlists neither file.After
BASE_TIPisorigin/<pull_request.base.ref>, orinputs.basefor manual dispatch.--baseis that tip's merge-base with the head, which is exactly the PR's own change.fetch-depth: 0,origin/mainis present.Not changed
🤖 Generated with Claude Code