Repository navigation
Goal history is Core's one RecordedGoalHistory record - #1301
Merged
Merged
Conversation
Core #3538 deletes GoalHistoryReply, an empty subclass of agent_comms.goal_history.RecordedGoalHistory that existed only so the owner socket had its own reply class. The owner's goal_history reply now decodes as RecordedGoalHistory, the record Core already ships. Seven consumers move to it, with no old-name alias: acp/agent.py (decode), agent_binding.py (unbound empty()), goal_interaction.py, screens/goal_details.py, tests/support/goals.py, tests/native/test_native_goal_owner.py and tests/textual/test_goal_owner_views.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dS2Kmg1WxNnAc78YHA
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
12 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired consumer change for OpenHCSDev/agent-comms#3538 (commit 7326056): goal history is one record, Core's
agent_comms.goal_history.RecordedGoalHistory.Summary in numbers
GoalHistoryReplyreferences in Toad: 16 → 0.What changed
Core deleted
GoalHistoryReply(runtime_requests.py) andGoalHistory(tools.py). Both were empty subclasses ofRecordedGoalHistorythat existed only so each boundary had its own reply class, picked by an argument torecorded_history.RecordedGoalHistorynow extendsToolResult, and both the MCP tool and the owner socket return it.Toad consumers moved, with no alias or re-export:
src/toad/acp/agent.py:get_goal_historydecodes the owner'sgoal_historyreply asRecordedGoalHistory.src/toad/agent_binding.py: the unbound binding returnsRecordedGoalHistory.empty().src/toad/goal_interaction.py,src/toad/screens/goal_details.py: annotations.tests/support/goals.py,tests/native/test_native_goal_owner.py,tests/textual/test_goal_owner_views.py: the scripted owner, its default empty history, and the hand-built history.Evidence
empty()encodes as{"failures": [], "history": []}on both sides.RecordedGoalHistoryis already on installed Core 3b1ab81, so this branch imports against today's install.GoalHistoryReply|GoalHistory|recorded_historyin src/tests/tools: these 7 files, 16 sites, now 0. The same search finds 18RecordedGoalHistorysites.Not done here
🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dS2Kmg1WxNnAc78YHA