Repository navigation
Context side bar opens for threads with no saved session - #1236
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
ContextInspection.read rebuilt the saved-session observation from thread.runtime.path, which an unstarted thread cannot answer. The runtime family owns it now (agent-comms#3280). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
trissim
marked this pull request as ready for review
October 25, 2026 07:00
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the context side bar for a thread that never saved a session crashed with
ValueError: Canonical saved session required, raised fromContextInspection.read(context_inspection.py:549) readingthread.runtime.path.readnow asks the runtime for its observation:thread.runtime.session_observation(comms.root, thread). An unstarted thread answers the empty observation. The side bar shows the thread's recorded context with no traceback.Needs OpenHCSDev/agent-comms#3280 merged first. Do not merge this before it.
Check (manual, installed runtime + this branch + #3262 overlay for Toad's
Refusedimport):ContextInspection.readon a declared never-started thread: runtimeUnstartedRuntime, sourceNoSessionObservation(), no raise. On a started thread: runtimePiSessionFile, source equalsSessionRevision.observe(files). No new test.Net src: agent_backend.py +4, pi_native_backend.py +7, session_revision.py +8, unstarted_runtime.py +4.
🤖 Generated with Claude Code
https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V