Skip to content

Restore the activity bar above the session details - #1234

Merged
trissim merged 4 commits into
mainfrom
fix/restore-top-throbber
Oct 25, 2026
Merged

trissim merged 4 commits into
mainfrom
fix/restore-top-throbber

Conversation

@trissim

@trissim trissim commented Oct 25, 2026

Copy link
Copy Markdown

910e2f0 (#1227, "Compact prompt box ... no loading bars") deleted both activity bars along with their module. Only the lower bar, the one under the session details, was meant to go. This PR brings back the upper one: it sits above the session details and reads the same activity owner as before (Conversation.working: local history reads, the turn owner, the observed thread). The comms chat view gets the same single bar at the top of its prompt stack, plus its history-read busy count back.

One bar class is left, so the Above/Below sibling pair and TopInk stay deleted.

🤖 Generated with Claude Code

https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V

trissim and others added 2 commits October 25, 2026 02:45
910e2f0 (#1227) deleted both activity bars when only the lower one,
under the session details, was meant to go. The upper bar comes back as
it was: AboveThrobber reading Conversation.working (history reads, the
turn owner, the observed thread), with the busy count that history reads
feed. The comms chat view shows that one bar in the slot its old bar had.

BelowThrobber and TopInk stay deleted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
@trissim
trissim marked this pull request as ready for review October 25, 2026 06:46
@trissim
trissim enabled auto-merge October 25, 2026 06:46
Copilot AI balanced review requested due to automatic review settings October 25, 2026 06:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

trissim and others added 2 commits October 25, 2026 02:49
busy_count was a second copy of whether WireHistory is reading its first
page: the rebind zeroed it mid-read, the finally took it to -1, and the
bar missed the next read. WireHistory now owns `reading`, set around
read_changes while nothing is drawn. Conversation.history_loading()
answers False; CommsChatView reads WireHistory.reading. working() reads
the turn owner, the observed thread and history_loading().

Deleted: busy_count, on_work_started, on_work_finished,
watch_busy_count and the zeroing on rebind.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
@trissim
trissim merged commit 1ce4872 into main Oct 25, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants