Repository navigation
Sidebar tooltip shows the thread model's text, not its repr - #1230
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
ThreadStatusRow.show joined str(value) over the tooltip parts, and row.model is a ThreadModel member, so the tooltip printed DeclaredModel(text='...'). The model family already answers its shown text: TextChoice.texts() is (text,) when given and () when absent, so the tooltip spreads that instead of stringifying the object (BOUND-8: the family's own text flattened by repr at the call site). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V
trissim
marked this pull request as ready for review
October 25, 2026 06:31
trissim
enabled auto-merge
October 25, 2026 06:31
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar tooltip: model text, not its repr
Hovering a thread row showed
DeclaredModel(text='openai-codex/gpt-6.1-sol').ThreadStatusRow.show(comms_sidebar.py:260) joinedstr(value)over its parts, androw.modelis aThreadModelmember. The family already owns its shown text:TextChoice.texts()gives(text,)when the model is given and()when it's absent. The tooltip now spreads that. BOUND-8: the family's own text was being flattened by a repr at the call site.tests/textual/test_welcome_view.py::test_a_thread_row_tooltip_names_its_model_by_text, 1 passed locally.Freeze profile, for the record (no code change here)
py-spy on Toad 59714 for 20 s; 172 main-thread samples:
observation.py:1497 results→connection.recv, unpickling observer results on the main thread. 24.4% of that is_dataclass_setstate.__eq__. 8.1% is theObservedThreadActivity.rowvar comparing wholeThreadStatusModels, each of which carries a fullThreadPresentationwith its notification window. 5.2% isKeyedModel.flushcomparing the same rows.The freeze is a flood, not a sync read on the switch. The fix belongs to the observer (Core): it sends unchanged sidebar snapshots and thread presentations whole. That's fork-cpu's surface, so it isn't fixed in this PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_013ejYrMLnLWah8wCDDcb57V