Repository navigation
Settle managed turns through TurnState.settles, not the deleted matches - #1193
Merged
Merged
Conversation
Core #2943 deleted TurnState.matches, so receive() at conversation_turn.py:271 raised AttributeError on every idle turn publication, including the owner snapshot Toad publishes when switching threads. Ask Core's TurnState whether the publication settles the held declaration, and delete the three matches_settlement methods nothing calls. The compaction peer now passes typed 128-bit turn ids, which #2943 also required. Requires OpenHCSDev/agent-comms#3076. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
trissim
marked this pull request as ready for review
October 24, 2026 19:51
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Pins agent-comms to 208a5b2ee, the merge of OpenHCSDev/agent-comms#3076, so this branch never ships calling state.settles against a Core that lacks it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
Toast on core-49156b4bb (Tristan, 2026-10-24 ~15:42), the cut-off end of the trace:
Core #2943 (merged 2026-10-23 22:42) deleted
TurnState.matches.ManagedTurnBinding.receivestill called it for every non-busy publication, including the owner snapshotOwnerSnapshotConsumer.thread_presentationpublishes when you switch threads. Reproduced in the installed runtime:ManagedTurnBinding.receive(TurnState())raises at conversation_turn.py:271.Fix
receiveasks Core's owner:state.settles(self.owner.state.active)(Let TurnState answer which idle publication settles a held turn agent-comms#3076 adds it: busy replaces, idle settles only the turn it finished, or anything when nothing is held).TurnOwner/AgentTurn/ManagedTurn.matches_settlement: zero callers, and one of them called the deleted method.tests/support/peers/typed_turn_events.pypassed"retired-producer"/"actual-producer"as turn ids; #2943 made TurnId a typed 128-bit id, so this test was already red on main (MalformedRecord) before it reached the UI. It now passesTurnId(...).Proof
tests/textual/test_compaction_turn_events.pyagainst agent-comms#3076:1 passed in 12.17s(stale finished cut refused, terminal publication settles the held turn).Merge order: agent-comms#3076 first, then this. Waiting on the commander's verdict.
Assumed:
ManagedTurnBinding._owneris always aManagedTurn(it is constructed and replaced only as one in this class).🤖 Generated with Claude Code