Skip to content

Publish saved transcripts through registry session locations - #1152

Merged
trissim merged 1 commit into
mainfrom
fix/session-location-ownership
Oct 23, 2026
Merged

trissim merged 1 commit into
mainfrom
fix/session-location-ownership

Conversation

@trissim

@trissim trissim commented Oct 23, 2026

Copy link
Copy Markdown

Paired with OpenHCSDev/agent-comms#2771, which replaces the registry's absolute session string with bus and external locations bound to the root that reads them.

  • Tests publish saved transcripts through RegistrySessionLocation.from_path(path, root) instead of SavedSessionFile(...) or a bare str.
  • Tests read a thread's transcript from thread.runtime.path, not Path(thread.session_file).
  • src/toad/screens/historical_sessions.py:121 shows thread.runtime.read_key instead of the location's repr.

Lands right after agent-comms#2771 merges, because these tests import its new declaration.

🤖 Generated with Claude Code

agent-comms #2771 replaces the absolute session string with bus and
external locations bound to the root that reads them. Tests publish
through RegistrySessionLocation.from_path and read the transcript from the
thread's runtime; the historical view shows the runtime's read key.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trissim
trissim marked this pull request as ready for review October 23, 2026 13:37
Copilot AI balanced review requested due to automatic review settings October 23, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim merged commit 58f0f8f into main Oct 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants