Repository navigation
Replace permission and renderer Any with concrete contracts - #1145
Merged
Merged
Conversation
Apply checked inference to conversation parameters and boundary returns. Preserve positional argument types through render-worker submission with a variadic generic. Use the existing CursorDirection parent, None-returning permission callbacks, and the actual external paint result types. Type the conversation path as the Path its constructor supplies.
trissim
marked this pull request as ready for review
October 23, 2026 10:54
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace four explicit Any uses with their actual contracts across six production modules. Permission callbacks return None; render-worker positional arguments preserve their types with a variadic generic; ui_theme paint produces Strip or Content. Cursor movement uses the existing CursorDirection parent, and cursor-presentation callbacks take BlockCursor. The conversation's reactive project path now declares the Path its constructor supplies.
Pipeline: autotyping 24.9.0 --aggressive, then Pyrefly 1.4.0 infer (-j 1, parameter/import inference; return/container inference off), followed by the full-production Pyrefly check. Corrected bad inferred bool callbacks and the UpCursor | DownCursor union. paint_text ignores its target and accepts Strip | None, preserving its current None callers and the backend's Strip contract.
Counts, from independent main b971751 (this branch does not include #1144):
Explicit Any stops (all ten remaining Name nodes):
Assumed: