Skip to content

Declare the style dependency of native width measurement on the layout - #93

Merged
trissim merged 3 commits into
mainfrom
refactor/native-width-dependency-supply-20261007
Oct 7, 2026
Merged

trissim merged 3 commits into
mainfrom
refactor/native-width-dependency-supply-20261007

Conversation

@trissim

@trissim trissim commented Oct 7, 2026 •

Copy link
Copy Markdown

A new NativeOptimalWidth dependency in _measurement.py is attached to Layout.get_content_width and delegates its style check to the native layout. The special case inside NativeWidgetWidth.styles_sensitive that checked whether a layout overrode that method is removed. One new test file checks the width dependency.

@trissim
trissim marked this pull request as ready for review October 7, 2026 09:16
Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 7bad33f into main Oct 7, 2026
3 of 22 checks passed
@trissim trissim changed the title Derive width style dependency from its native layout declaration Declare the style dependency of native width measurement on the layout Oct 11, 2026
@trissim
trissim deleted the refactor/native-width-dependency-supply-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants