Skip to content

Skip held-subtree scans when no subtrees are held - #79

Merged
trissim merged 4 commits into
mainfrom
perf/sidebar-layout-invalidation-20261006
Oct 6, 2026
Merged

trissim merged 4 commits into
mainfrom
perf/sidebar-layout-invalidation-20261006

Conversation

@trissim

@trissim trissim commented Oct 6, 2026 •

Copy link
Copy Markdown

The compositor and screen only walk the previous scene's ancestry when there are widgets with pending layout changes. Compositor.deferred_regions returns right away for an empty set of roots, and the screen's sender check and layout filtering are guarded the same way. One test file has its callback test renamed and checks the app task.

@trissim
trissim marked this pull request as ready for review October 6, 2026 21:20
Copilot AI balanced review requested due to automatic review settings October 6, 2026 21:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 19f5aae into main Oct 6, 2026
2 of 22 checks passed
@trissim trissim changed the title Skip empty held-subtree scans in layout and publication Skip held-subtree scans when no subtrees are held Oct 11, 2026
@trissim
trissim deleted the perf/sidebar-layout-invalidation-20261006 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants