Skip to content

Skip geometry checks when writing styles on a detached node - #113

Merged
trissim merged 2 commits into
mainfrom
perf/native-detached-rule-publication-20261007
Oct 8, 2026
Merged

trissim merged 2 commits into
mainfrom
perf/native-detached-rule-publication-20261007

Conversation

@trissim

@trissim trissim commented Oct 8, 2026 •

Copy link
Copy Markdown

Styles._update_rules in styles.py checked whether each changed rule affects geometry, even for temporary styles that have no node and so nothing to relayout. The check now runs only when the styles belong to a node. Rule validation and publishing are unchanged, and attached nodes that are not yet mounted still get the geometry check. A stylesheet test is adjusted.

@trissim
trissim marked this pull request as ready for review October 8, 2026 03:15
Copilot AI balanced review requested due to automatic review settings October 8, 2026 03:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@trissim
trissim merged commit 6ebaa3a into main Oct 8, 2026
2 of 22 checks passed
@trissim trissim changed the title Skip discarded geometry analysis in detached mount style preparation Skip geometry checks when writing styles on a detached node Oct 11, 2026
@trissim
trissim deleted the perf/native-detached-rule-publication-20261007 branch October 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants