Repository navigation
Pass the real box mode into layout height dependency checks - #106
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 7, 2026 23:06
trissim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The height dependency checks assumed the most conservative box mode, so a fractional width was treated as reading content width even when the box was not sized optimally.
HeightDependency.dependsandbox_dependsin_measurement.pynow take agreedyargument, andwidget.pypasses the actual mode through the box and arrangement checks. Native content measurements still choose their own mode. Tests are added for custom widths and for style and child changes.