Repository navigation
A closed PR's head can be superseded again - #3768
Merged
Merged
Conversation
The LOST row says to record why a closed PR's commits are dropped, and judge superseded is that record, but the verdict read required an open PR, so every row refused with "no longer an open source". Each verdict now declares the read it stands on: superseded reads any state, everything else still requires open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at 75a7d9f, every finding: |
Superseded decides closed heads, so PreparedHeadReview cannot promise an open one. Its field now states what its consumers read. Fixes the debt-src finding at order_tools.py:235 and the long line at head_review.py:138. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7
trissim
force-pushed
the
claude-nra/closed-superseded
branch
from
October 31, 2026 05:02
96d24dd to
9b21032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOST rows could not be cleared: the row says record it, the recorder refused. 1 read, 1 test.
The bug
HeadVerdictTool.applyreadrequest.current(), which goes throughOpenPullRequestHead.from_forgeand refuses any closed PR (head_review.py: "no longer an open source").ClosedUnmergedPullRequestis cleared byjudge supersededon exactly those closed PRs, so #3719 refused. claude-board reported it (3087d41e2415); it came in with the #3670 carrier I admin-merged.The fix
HeadVerdict.current_headdeclares the read a decision stands on: the open read by default,closed_or_openonSupersededHeadVerdictonly. The moved-head refusal holds on both.forge_readis the one query both use, so a closed PR still can't be armed:armlives only on the open read.Proof
test_only_superseded_may_decide_a_closed_head: superseded records on a closed PR, ok still refuses. Not seen on an installed build or on a real LOST row.Not fixed
test_retained_head_verdict_precedes_the_published_lost_packetfails on main at its own line 1298:CommanderHeartbeat.register(comms.registry)raisesCan only register classes. Its other three parameters fail on an invalidStrikeReasonin the fixture. Neither comes from this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7