Repository navigation
The queue's group commit carries the verdict status main requires - #3711
Merged
Merged
Conversation
Main is about to require agent-comms/review directly, as RulesetGates checks. Core posts that status on a pull request's head, so a merge group's commit never had it and every queue entry would hang. The group job already verifies the head's verdict; it now posts the status on the group commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 30, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the one real gap in
commander_native/review_queue: an active rule on main must requireagent-comms/reviewdirectly.Before: ruleset 25439636 requires
review-verdict, which checks the verdict only onmerge_group. It is green on every PR with no verdict (#3613:review-verdictSUCCESS,agent-comms/reviewPENDING), so auto-merge arms and the failure only appears in the queue.After: the ruleset requires
agent-comms/reviewin place ofreview-verdict. A PR can't enter the queue without a verdict on its head.Why the workflow changes
Required checks also apply to the merge group's commit, and Core posts this status only on PR heads. Without this change every queue entry would hang for the 60-minute check timeout. The
review-verdictjob already verifies the head's verdict on the group; it now posts the status on$GITHUB_SHA.The merge queue stays. It's the only re-check against latest main (
strictis off), and 14 of the last 30 merged PRs had auto-merge armed. The 37 failed runs out of the last 40 come from the non-requiredinstall-rehearsal; that is a separate red.Already on main
HeadReviewRecordtodos.py:4603;QueueBypassGuardqueue_bypass.py:197, which refused my admin merges without a verdict this session. Bypass actor is admin role only.Order of landing
This merges first, because a merge group runs the workflow from its own commit. The ruleset swap follows. Proof is the next real PR that goes through the queue with the new rule. Not run yet: a workflow that only fires on
merge_groupcan't be run locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01XbFMSpSd8zQxyozgEV2Re7