Skip to content

Declare formbridge as a stack source - #3692

Merged
trissim merged 1 commit into
mainfrom
hotfix/stack-formbridge-source
Oct 30, 2026
Merged

trissim merged 1 commit into
mainfrom
hotfix/stack-formbridge-source

Conversation

@trissim

@trissim trissim commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Hotfix: 1 file, +2 lines.

Defect. stack/pyproject.toml owns source selection for Toad's transitive requirements, but formbridge (a Toad dependency from our own repo) was left to a stack/uv.lock pin from 2026-10-16 (ebe2fa91). Toad main now imports formbridge.forms.declared_fields (toad/setting_effects.py:5, module added in formbridge 0e04650b on 10-28). The #3566 carrier's checker stack (tools/checker_stack.py resolve(), deliberately no --upgrade) kept the stale pin while materializing Toad main, so debt-tools on #3670 died at tools/cutover/carry_toad_key_mode.py:15 with ModuleNotFoundError: No module named 'formbridge.forms.declared_fields' (run 41048620045). Main's own gate hid it only because it runs uv lock --upgrade.

Fix. Declare formbridge beside metaclass-registry and ui-theme (branch = "main", override). IntegrationInput.source_urls (head_review.py) derives the paired-repository universe from these declarations, so the checker now materializes formbridge main with Toad main, and local_packages treats it as local. No pin to an old Toad, no import guard.

Proof. Rerun of #3670's debt-tools after merging main.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XbFMSoWgC3ZwKzjT4SwMDu

The stack owns source selection for Toad's transitive requirements, but
formbridge, a Toad dependency from our own repository, was left to a lock
pin from 2026-10-16 (ebe2fa91). Toad main now imports
formbridge.forms.declared_fields (added 10-28, 0e04650b), so any resolver
that keeps lock pins (the checker stack's non-upgrading lock in the #3566
carrier) installs a Toad newer than its formbridge and debt-tools dies on
ModuleNotFoundError through tools/cutover/carry_toad_key_mode.py:15.
Declaring it beside ui-theme makes it a local main-branch package, so
IntegrationInput.source_urls materializes formbridge main with Toad main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XbFMSoWgC3ZwKzjT4SwMDu
Copilot AI balanced review requested due to automatic review settings October 30, 2026 11:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim
trissim enabled auto-merge October 30, 2026 11:53
@trissim
trissim merged commit 532d949 into main Oct 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants