Repository navigation
Admit the reviewing mark wherever an order takes a head verdict - #3668
Merged
Merged
Conversation
CheckedProblemOrder.review_verdicts declared only ok and back; the reviewing mark was added by ClaimedProblemOrder alone, so `judge reviewing --problem` was refused on every linked-but-unclaimed order. The base declaration now admits all three, and the order-state transition the mark causes moves onto the order family: under_review keeps the order as is, and only a claim becomes ReviewingProblemOrder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 30, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong:
agent-comms-commander judge reviewing --problem P --pr N --head SHAwas refused with "This order takes head verdicts: ..." on every open order whose linked PR was not yet claimed (hit on #3613, #3595, #3609, #3594, #3650), so those reviews went in without their under-review mark.Where/why:
RecordOrderHeadVerdict.prepare(src/agent_comms/todos.py) checks the verdict againstcurrent.order.checked().review_verdicts(). The base declaration onCheckedProblemOrderlisted only ok and back;UnderReviewHeadVerdictwas appended only by theClaimedProblemOrderoverride, because the mark'sjudge_ordercopied the order intoReviewingProblemOrder, which needs a claim.Fix: the base
review_verdictsdeclares all three (a reviewing mark is admissible wherever ok/back are), the Claimed override is deleted, and the state change the mark causes moves onto the order family asunder_review(record): the base keeps the order (the stored head review is the whole mark),ClaimedProblemOrderbecomesReviewingProblemOrder.UnderReviewHeadVerdict.judge_orderdispatches to it.Test:
test_a_reviewing_mark_on_an_unclaimed_linked_order_is_recordedin tests/test_head_review.py records the mark on a linked, unclaimed order and reads back the stored review. Four assertions in tests/test_board_verbs.py that pinned the old restriction now assert the mark is offered. The 11 other failures in these two files fail identically on origin/main 3a4b2ce (board wording, and a flaky Git "not our ref" fixture).🤖 Generated with Claude Code