Repository navigation
ClientTypeErrors measures AgentCommsProject through the audit's project parameter - #3637
Merged
trissim merged 1 commit intoOct 30, 2026
Merged
Conversation
…ct parameter #3630 narrowed ClientTypeErrors.parts(repo: AgentCommsProject) to read repo.clients, and mypy rejected the override against Runner.parts(repo: Project) [override]; CI's debt-tools went red on #3566. The pinned audit now makes Runner, Compared and SideCounts generic in the project they read (refactor-audit fix/generic-project-runner b80510df), so the measure declares SideCounts[AgentCommsProject] and its parts takes the project it actually reads, with no narrowing. mypy (the TypeErrors measure's invocation) on tools/agent_comms_project.py: 1 error before, 0 after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RnH6dS2Kmg1WxNnAc78YHA
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3566's red debt-tools:
tools/agent_comms_project.py:298: error: Argument 1 of "parts" is incompatible with supertype "audit.ratchet.Runner"; supertype defines the argument type as "Project[Any]" [override], introduced by #3630.Numbers: 2 files: 1 line in
tools/agent_comms_project.py, plus the submodule pin. mypy (the TypeErrors measure's own invocation,mypy --explicit-package-bases --no-error-summarywithMYPYPATH=tools:src:<audit scripts>) ontools/agent_comms_project.py: 1 error before, 0 after.What changed
ClientTypeErrors(audit.checkers.SideCounts[AgentCommsProject]): the measure names the project it reads. Itsparts(repo: AgentCommsProject, ...)is now the declaredrepo: P, not a narrowing override.src/agent_comms/skills/refactor-auditpinned to Measures are generic in the project they read refactor-audit#12, merged asae542194, whereRunner/Compared/SideCountsare generic in a contravariant project parameter defaulting toProject.Required last commit
Done: refactor-audit#12 merged as
ae542194, and the submodule pins that main merge commit (head9c3a44e5), the same tree asb80510df.Proof
import agent_comms_project:ClientTypeErrors.__mro__has SideCounts then Compared, and it's still a registeredComparedmember.Base:
work/checkout-caller--P883(#3566). The ratchet is being replaced by NRA (OpenHCSDev/NominalRefactorAdvisor#155 plus the agent-comms removal PR). This is only what unblocks the queue fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01RnH6dS2Kmg1WxNnAc78YHA