Require explicit new-agent channels and collect required fields before construction

src/agent_comms/channel_targets.py

@@ -22,10 +22,9 @@
 if TYPE_CHECKING:
     from .audience_manifest import AudiencedMessage
     from .frozen_recipient import FrozenRecipient
-    from .catalog_document import CatalogAccess, CatalogDocument
+    from .catalog_document import CatalogDocument
     from .channels import Channel
     from .cli_command import CliCommand
-    from .cli_result import CliResult
     from .comms import Comms
     from .goal_management import Goals
     from .historical_views import ChannelHistory, DMHistory, HistoryView
@@ -163,11 +162,6 @@ def available(self, snapshot: RegistrySnapshot) -> bool:
     @abstractmethod
     def resolve(self, snapshot: RegistrySnapshot, require_channel: Callable[[str], Channel]): ...
 
-    @abstractmethod
-    def bindings[C: CliCommand](
-        self, declaration: type[C], comms: Comms, channel: SurroundingChannel, resolved,
-        *, project: Checkout, snapshot: RegistrySnapshot, catalog: CatalogAccess,
-    ) -> tuple[C, ...]: ...
 
     def history_view(self, viewer: DisplayViewer, require_channel: Callable[[str], Channel],
                      channel: type[ChannelHistory], direct: type[DMHistory]) -> HistoryView:
@@ -178,7 +172,7 @@ def history_result(self, require_channel: Callable[[str], Channel], messages: tu
         raise ValueError("History requires a #channel or DM peer.")
 
     def contexts(
-        self, declaration: type[CliCommand[CliResult]], channel: ChannelSelection,
+        self, declaration: type[CliCommand], channel: ChannelSelection,
     ) -> tuple[SurroundingChannel, ...]:
         return (NoChannel(),)
 
@@ -394,7 +388,7 @@ def history_result(self, require_channel: Callable[[str], Channel], messages: tu
         return self.history_result_type.for_target(self.name, messages, has_older)
 
     def contexts(
-        self, declaration: type[CliCommand[CliResult]], channel: ChannelSelection,
+        self, declaration: type[CliCommand], channel: ChannelSelection,
     ) -> tuple[SurroundingChannel, ...]:
         return declaration.selection_channels(channel, self.name)
 
@@ -411,11 +405,6 @@ def resolve(self, snapshot: RegistrySnapshot, require_channel: Callable[[str], C
         thread = snapshot.require(self.selected_name(snapshot))
         return ResolvedThread(thread, snapshot.status(thread.name))
 
-    def bindings[C: CliCommand](
-        self, declaration: type[C], comms: Comms, channel: SurroundingChannel, resolved: ResolvedThread,
-        *, project: Checkout, snapshot: RegistrySnapshot, catalog: CatalogAccess,
-    ) -> tuple[C, ...]:
-        return declaration.thread_bindings(comms, resolved.thread, resolved.status, channel, catalog=catalog)
 
     def validate(self, message: Message) -> None:
         if message.sender == self.name and message.type.conversation_message:
@@ -560,11 +549,6 @@ def resolve(self, snapshot: RegistrySnapshot, require_channel: Callable[[str], C
                         if channel.matches(thread.tags))
         return ResolvedChannel(channel, members)
 
-    def bindings[C: CliCommand](
-        self, declaration: type[C], comms: Comms, channel: SurroundingChannel, resolved: ResolvedChannel,
-        *, project: Checkout, snapshot: RegistrySnapshot, catalog: CatalogAccess,
-    ) -> tuple[C, ...]:
-        return declaration.channel_bindings(comms, resolved, project=project, snapshot=snapshot, catalog=catalog)
 
     def validate(self, sender: Message | None = None):
         from .channels import BuiltinChannelView
@@ -652,11 +636,6 @@ def destination_names(self) -> tuple[str, ...]:
     def resolve(self, snapshot: RegistrySnapshot, require_channel: Callable[[str], Channel]):
         return self.project
 
-    def bindings[C: CliCommand](
-        self, declaration: type[C], comms: Comms, channel: SurroundingChannel, resolved,
-        *, project: Checkout, snapshot: RegistrySnapshot, catalog: CatalogAccess,
-    ) -> tuple[C, ...]:
-        return declaration.project_bindings(comms, resolved)
 
 
 _TAG_CHARS = set("abcdefghijklmnopqrstuvwxyz0123456789-_")