Repository navigation
Scope HolderSeenProbe to its test; repairs fixture writes scripts entry - #3240
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q8rVa3cPyXzpCKyR8XvM8W
The probe was declared at module level in tests/test_install_worker_holds.py, so it stayed in RuntimeProbe.__registry__ for every later test in the worker and OutgoingWire read it as an installer probe outside the package. Declare it inside the one test that uses it and pop it from the registry in finally. test_repairs' tree() fixture now writes the pyproject.toml scripts entry Package needs since #3184. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q8rVa3cPyXzpCKyR8XvM8W
trissim
changed the title
trissim
marked this pull request as ready for review
October 25, 2026 05:06
trissim
enabled auto-merge
October 25, 2026 05:06
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three main reds (ci.yml, Linux):
test_module_layers_clients.py::test_outgoing_wire_matches_the_tree_that_declares_ittest_module_layers_clients.py::test_outgoing_wire_fails_on_a_renamed_field_or_a_missing_probetest_repairs.py::test_a_local_import_moves_up_unless_a_load_time_import_leads_backCause of the OutgoingWire reds: test pollution.
tests/test_install_worker_holds.pydeclaredHolderSeenProbe(RuntimeProbe)at module level.__init_subclass__put it inRuntimeProbe.__registry__for the life of the xdist worker, so any later test on that worker that read the installer's probes (OutgoingWire,tools/module_layers.py:404) got a member declared undertests/, andrelative_toblew up. The probe now lives inside the one test that uses it, andfinallypops it from the registry (same pattern astests/guards/test_coordination_ownership.py:62).Not done, on purpose: narrowing
DeclaredFamily.discover_membersto members declared inside the package. That restates membership by file location beside the registry, and it broketest_new_declared_table_is_installed_without_schema_roster_edit, which is the contract (declare a table, get it installed). Reverted.test_repairs: since #3184,
Packageneeds the[project.scripts]entry;tree()now writes it.Proof:
nice -n 19 timeout 600 python -m pytest -q -p no:xdist tests/test_install_worker_holds.py tests/test_module_layers_clients.py tests/test_repairs.py tests/guards/test_coordination_ownership.pygives 17 passed.Assumed:
TypedTabletest members (tests/round2/test_typed_table.py,tests/test_table_mutation_capabilities.py) still sit in the registry, but no production scan reads the bareTypedTablefamily today, so they leak into nothing. If a scan ever reads it, they need the same scoped declaration.🤖 Generated with Claude Code
https://claude.ai/code/session_01Q8rVa3cPyXzpCKyR8XvM8W