Repository navigation
Repair two history fixtures that held shapes no carried bus has - #3003
Merged
Merged
Conversation
test_info_claim_history: the 1477 fixture still held the pre-carry claim row (admission, owner_admission_generation, scope version 1). The retired carries (retired_claim_fields.py and carry_wake_claim_turn_ids) rewrote every stored row to resource_scope, owner_claimed_generation and version 2; the live bus holds 0 admission keys and 0 version-1 scopes. The fixture now holds the carried shape. Red since #2701 (05fcdfe). test_historical_views: the archive mutation wrote the display projection (role HistoricalConversationRole, undeclared) back into a bus. No src path writes a projection; build the mutation as a plain Message instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two main reds were stale fixtures holding shapes no real bus has; test-only.
Head: tests/test_info_claim_history.py + tests/test_historical_views.py 24 passed; on main 2 failed / 22 passed.
🤖 Generated with Claude Code