Repository navigation
Declare the stored-format fixture's second spelling as an Id128 kind - #2973
Merged
Merged
Conversation
The fixture record subclassed Id128Text directly. Since 56cfe9f Id128Text is NominalSpelling[Id128], whose __init_subclass__ finds the value type in a NominalSpelling[...] base, so the bare subclass raised StopIteration when the stored_formats probe imported it and all six cases failed before measuring. The same-spelling case is now a kind (an Id128 subclass inheriting Id128Text), which is how the codec declares one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main red:
tests/test_carry.py::test_a_stored_record_format_change_bumps_its_version_and_ships_a_carry, all 6 cases, red on main since #2943 (56cfe9f).Id128TextbecameNominalSpelling[Id128](field_codec.py:1892), andNominalSpelling.__init_subclass__(field_codec.py:1735-1742) needs aNominalSpelling[...]base. The fixture's bareclass RootId(Id128Text)raisedStopIterationinside the stored_formats probe, so every case died before measuring. The ratchet was right; the fixture was stale.The same-spelling case is now a kind,
class RootKind(Id128), which is how the codec declares one. Test only.Local: 6 passed (was 6 failed on 30f3093). The
str->Id128Textcase still counts 1, so the test still catches a real format change.🤖 Generated with Claude Code