Repository navigation
Let structural field representations own their behavior - #2966
Merged
trissim merged 6 commits intoOct 24, 2026
Merged
Conversation
trissim
marked this pull request as ready for review
October 24, 2026 01:50
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StructuralRepresentation owns the absence of a field representation: it selects structural projection, schema and decoding and contributes no codec owners. Represented members own the other behavior. The zero-or-one tuple and every representation presence probe from 7f04146 are deleted.
Head
d0a24e2f7de1330de0f2a157c665ea611b71536f, baserefactor/id128-nominal-type, following merged #2945 on its original branch. Reviewer's requested InputId.mint fixture change is included. src/ and tools/ are byte-identical to the checked source head5c41d99b8f816f0bdc18d342e9b810deb3fd2136; the final commit changes only tests/test_selected_tool_broker.py.Final implementation
A: presence-probe grep
B: exact requested debt commands
Executed nice 19 with timeout 300 and PYTHONPATH=src:tools. Final source revision 5c41d99; HEAD's src/tools diff against it is empty, so the test-only final commit does not change either measured tree.
No other finding remains. No baseline, exemption or pragma changed. No test suite or test replay ran.
Ruff check ran on all 145 Python files returned by git diff --name-only origin/main -- '*.py': 1,159 findings overall in inherited/untouched code, zero on the final changed lines. No whole-file formatting outside the ordered carry file.
KeyError grep
Before, at 86aef8b:
After:
The two remaining handlers are unchanged: the spelling member lookup and _structural_decoder. Candidate lookup and represented compilation catch nothing.
Revised C: every actual producer digest change
One script invokes producer_stamp.stamped_digests() on an archive of 86aef8b and the clean checked HEAD source in fresh interpreters. The final test-only commit has identical src/tools. All eleven registered production projection digests differ.
Finding: ten tables have no matching declared codec/value column. Their columns are primitive types and StructuralRepresentation.producer_owners returns (). Their digest changes because ProducedTable is itself an existing hashed owner and its producer_owners source changes here. No narrower hash or hidden owner removes that dependency. MessageIdentitySource additionally reaches FieldRepresentation through its MessageId column.
bc57e1d78a849c5becc377632adadfaadf725433f3d3c5f5afa74c31263de69467504a16bb0180238612b950cd5bd292b2ff3738cddd5b8ca4f6c00d4ba77c621403608744e1324ade348c7ac153ee48a42992d848cb0fca14ce1a523c39f1dafda7823abaa3aa012f05dbadab8f3e98d65b48b435632ae38e9a6b1d29064dbb75bd85cad57706f53056e3eea84074d797ad4edf8f90e792fb57582a4ce2ed88f06ffbd5b3ff80a27b906196eaf093d91a3695ac31ce9c4347c27440eeb9dcc544eac88cc9389bf74f39b1f7edc34b3116d87eabce4221f25412a768d3804a296f18f39634b1761c2d4e0702375f1d1ff7d5468e16f52247cb00153d9784909a85eaa85f36105d7428e52da82e5e0ac89eab9c01d9d11996a349395b29cf582d506e0eb03311f7c90fdd32fec16681fa244882af6fe3309bf4b5f54b84ac3a5fcf1e112b8fdaa3a81e17ca0097d5b0d9ec3f211f25dc0cbff495d818db4b72b2b86ce77c8c59ec32c2e04a3a57f363624a0cc068b9131327be712e09ca3291b101454194b39741d32840c72a021f999365dc9d31f1d14cbe1047ef771d1f74ff800ccb9dd5792d419c4c0de88929487e61f1613a27ec28a691d09f0bd6de11219e9b97d2d7a20c886fc537d925c769fc0e8486149f25f5eda4e67c370f10a057a35724a5c3af9b9ff16bad7e9d3533e2d2975383ee4c7a030675bf330f5dcd13a1d6f035d022aa807bd5c0cfd467b451c04140b75f8992601ff685150f465fc27dfbfda460b1e74ade3e2c54eb2fe59ccf01c7fe4991c2302f3c249938142d7ac9babf5e9a20c633e0fb99840909f9370f6d40a3f5863e6869081dd357a99cab52887129c322c71fecedbe8db8a48d375ad4407142cb206f87cd0b59f2d0f38954ca2824accbe87753a101301a69dbfe9e5ce03d8b26bfc3e731ea28d61ebb96435ff1037387f6b3e6fc2cf1054d937c0df31991ff327e035f4a3ed036d3e087Primitive columns for those ten findings:
Assumed and representation-query callers
git diff --stat 86aef8b61..HEAD:git diff --stat origin/main...HEAD: