Repository navigation
Assert saved identity collision on the lookup read - #2960
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 23:47
trissim
enabled auto-merge
October 23, 2026 23:47
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The saved-creation-collision test still expected a history read to resolve registry identities. #2893 made RegistrySnapshot.by_lookup lazy; assert RelationViolationError when that lookup is read instead.
Only tests/test_envelope_bus_integration.py:152 changes:
Bob's refused claim and the alice-only bus-row assertion stay intact. The dict call forces the lookup and avoids a bare-expression B018 finding. No src changes. Backend's child-script Bus import near :238 is untouched.
This follows #2957, which merged as 922ac87 and was already merged when I checked this additional order; GitHub cannot append a commit to that merged PR. It uses the same main-reds branch, updated to origin/main.
Validation: read RegistrySnapshot.by_lookup at registry_document.py:1023-1031. The commander supplied the behavior proof on 4f62186; no local tests, ratchets or suites ran. ruff check ran on the sole changed Python file and reports only existing I001 at :6 and E501 at :66, neither on the changed line. git diff --check passed.
Assumed: the supplied by_lookup refusal is the intended public identity-resolution read. Backend still owns its separate child-script import edit; this PR changes only :152.