Repository navigation
Assert bare Path encoding uses its declared text boundary - #2956
Merged
Merged
Conversation
The Path decoder deliberately registers Path origins. Assert the exact encoded path instead of requiring the obsolete TypeError. No production source changes.
trissim
marked this pull request as ready for review
October 23, 2026 23:31
trissim
enabled auto-merge
October 23, 2026 23:31
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PathDecoderdeliberately registersPathorigins, so bare paths now encode throughPathText. The scalar-capability test still expectedTypeError, contradicting the declaration and keeping main red since #2469.Replace only that obsolete refusal with the exact declared value:
No
srcchanges. No tests or ratchets run by this unit. The commander reported its independent proof on main3593a631e: 121 passed, 1 skipped across test_field_codec.py, test_turn_record.py and test_declarations.py.Required lint:
ruff check tests/test_field_codec.pyreports 14 findings on existing lines outside this hunk; none on the changed assertion. No formatting sweep or unrelated edit.Reviewer #2943 touches other hunks in this file; this branch will merge main if required by its landing.
Assumed: bare
Pathencoding through_PathDecoderis intentional, as its declaration and test_field_codec_comparison.py already require; the exact output remains/saved/history.