Repository navigation
Name flock holders on the first store lock wait - #2902
Merged
Merged
Conversation
trissim
marked this pull request as ready for review
October 23, 2026 20:47
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-tools at a276ead, every finding: |
|
debt-src at a276ead, every finding: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contended store acquisition used to wait silently until success or timeout. It now writes one flushed stderr line on its first BlockingIOError, naming every flock holder, then continues through the existing contention budget and sync/async waiting paths.
IDEN-2: the general flock-holder mechanism was named and located as a route-only facility. Move that existing mechanism to Platform so the lower store layer and route refusal share it.
Base: origin/main da12825, which contains #2892 (merged as 5d331d0). EmptyCommandLockHolder was already deleted there because empty Linux cmdline is ProcessLookupError; it stays deleted rather than adding a dead family member.
Requested source/test/tool grep:
Consumer search found no test imports of the moved family/parser and no test solely pinning the old name. No test changes were needed. AST inspection covered the declarations and consumers before editing; all three changed modules parse with zero omissions; git diff --check is clean. No test runs.
HARNESS-PLAN step 3's lock-wait bullet only. This does not claim the whole plan or an installed command qualification.
Assumed: do not resurrect EmptyCommandLockHolder after the #2892 correction. Existing Linux procfs lookup failures propagate; no catch masks a failed lookup as an empty holder set. The contention line is emitted on the first BlockingIOError, including an immediately exhausted budget, as the order specifies.