Repository navigation
Delete the second bus install after a root is claimed - #2862
Merged
Merged
Conversation
wire() claims the root, and RootRuntime.adopt creates its bus there (root_runtime.py:69). Sixty Bus.install(Bus.path_in(x.root)) calls after wire() installed that bus a second time; they are gone, with the two comms fixtures that existed only to make that call. Tests that build a bus on a directory no root claims keep their install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
…nstall # Conflicts: # tests/test_acp.py # tests/test_command_families.py # tests/test_native_only_execution.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wire()claims a root, and claiming creates the root's bus (RootRuntime.adopt,root_runtime.py:69, #2854). So everyBus.install(Bus.path_in(x.root))written afterwire()installs a bus that already exists.What this deletes
Bus.install(Bus.path_in(<comms>.root))lines, plusnative_backend_fixture.py'sBus.install(Bus.path_in(wire(root).root)), which becomeswire(root). None are in src.comms(comms)fixtures (test_importing.py,test_turn_goal_account.py) whose only job was that call.Busimports those deletions left unused, plus 3 more dead imports in the touched files that ruff flagged.What it keeps
wire()has claimed:check_root.py:100(installs with history),conftest.installed_comms(models what the installer leaves on disk),test_bus*,test_install,test_cli_execution, and similar tests.Proof (all touched test files,
-p no:xdist)origin/main082b42c worktree:test_native_only_execution::test_headless_uses_existing_owner_runtime_and_owner_projectand thetest_acp::TestHandlerscases (intermittent):PublicationActivationBlocked: requires a private bus root.test_owner_process, which uses the changed fixture:MissingGoalGenerationError.🤖 Generated with Claude Code