Repository navigation
Use InputDocument for reply reservation and unresolved selection - #2642
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
enabled auto-merge
October 23, 2026 07:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal reply review reconstructed missing input reservations and unresolved-owner filtering in Goals._goal_input_review even though InputDocument.record and InputDocument.unknown already own those decisions. Use the existing document methods and delete the caller copy. Inspection remains in memory; explicit review still validates the observed rows before persistence.
The original syntax inventory covers 464 source modules and 108 lexical record/unknown/lookup/items_with sites; semantic reads traced InputDocument and InputDispositions recording and review consumers. Arbitrary dynamic binding remains unresolved. Before receipt: /home/ts/.cache/agent-scratch/commander-control-plane/goal-input-document-owner-before.json. No new helper, type, store or producer.
The prior checkpoint passed 81 lock/input/disposition cases. Local affected-file checks on this rebased head are running under timeout300; results follow in this PR. No installed/native qualification is claimed. This single commit follows merged #2638 and is independent of #2630.
Final rebased head d487cfe: 76 affected-file tests passed in 5.89s under timeout300 (test_goal_reply_lock_scope.py and test_input_disposition.py). Remote matched HEAD. Merged on main.