Repository navigation
P440: delete dead delivery verb and use the unit tool - #2584
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
P440 installed command acceptance — 2026-10-21Selected runtime: Results
This is a continuous workflow on a fresh CheckRoot copy of the configured saved history, using a tiny generated Git repository and an external-only fixture registration for the review event. No agent processes were launched; all fixture process identities were checked. This does not claim a separate provider/Toad/UI qualification. No pytest tests ran this turn. The installed command's live board also exited 0 and displays the original P440 claim ( Failed verification setup, not product failures
Retirement
Hosted-check wording correctionThe earlier #2584 report's “all six passed” described PR job conclusions, not six executed substantive checks. |
P440: delete the dead delivery CLI; keep the unit tool
TIME-1:
CommsOrderDeliverToolowns holder delivery.DeliverVerbwas a forwarding copy behind a commander-fork-only preflight, so ordinary holders never reached its gate. Delete the copy rather than widen--forkor add another caller family.DeliverVerb, its help and now-unused tool import (22 production lines removed).test_order_claims.pytoThreadCaller("worker").invoke(CommsOrderDeliverTool(...), comms), reusing the first test's existing request.proof_build_checkoutsfixture into the test module; its held-commander fixture needs it when this file runs alone.comms_order_deliveras the unit's own tool; no replacement verb or alias.CommanderVerb.apply,CommanderForkCaller.commanding,register_commander_child,CommsOrderDeliverTool, or P440's merged identity work.Source evidence
Fresh main:
d683dffd0a8aee75a40acb1a6da2136320fa6a7a.Before/after existing refactor-audit
Packageinventory: 440 production, 471 test, 14 tools Python modules; zero parse omissions. Paired Toad source atde66b5120c2cc9ed29d86b84aa0e5a3bc22c32d9: 283 modules, zero omissions, no bindings to either class or literalorder deliverconsumers. After: no DeliverVerb declaration or dead CLI calls; three references to the unchanged tool in the test family. The tool is declared in tools.py; command-family membership derives from class declarations. Two dead CLI call sites, in the first test and its shared helper, are the complete tracked Python consumer set. Skill instruction is migrated with them. Dynamic external clients/MRO are not resolved by this AST inventory; the registration and tool boundary were read semantically. NRA was not run (last known shared environment lacks tree_sitter).All 32 assertions are AST-identical to main. Protected guard methods are AST-identical. Ordered whole-src check
git grep -n 'class DeliverVerb' -- src | wc -l: 0 (main: 1).git diff --check: clean.Verification
Only
tests/test_order_claims.pyis run locally, under timeout 300,-n 0, and faulthandler timeout 60; normal conftest retained.proof_build_checkouts; zero cases executed. Not a behavioral baseline.-p test_proof_build,PYTHONPATH=src:tests: 5 executed, 0 passed, 5 failed in 5.53s, eachRelationViolationError: This thread is not a declared commander fork.7b68ae2312622ec40db9165b7fb60e3e004d4d95, normal standalone invocation with the imported shared fixture: 5 executed, 5 passed, 0 failed in 15.68s. Both runs emitted the existinggoal_owner_fixturepytest assertion-rewrite warning.7b68ae2312622ec40db9165b7fb60e3e004d4d95: all 6 passed (smoke,native-scripts,install-rehearsal,review-verdict,debt-src,debt-tools), run39696185747. No local ratchets or full suite.comms_order_deliver, on orderf6f92e024e5c, revision 82. The current installed commander's realorder boardexited 0 and shows P440 held by unit-mi-1b, PR P440: delete dead delivery verb and use the unit tool #2584 at this head, Claimed by the unit, waiting on the commander's verdict. This demonstrates the real holder tool/board path on the current installation, not that the new build is installed.Remaining application acceptance
Not installed or live-qualified by this PR report. After installation: original P440 fork order/check and superseded verdict work under their commander, sibling competition is refused, and an actual holder uses native
comms_order_deliverand appears claimed by that unit on the board. No source-only native run or hand-built runtime is attempted.Assumed