Repository navigation
P448: generation-owned failure evidence and report-only blocked work - #2564
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P448 follow-up: generation-owned evidence and stop without reissuing orders
Follow-up to #2529. The generation owns its failed attempt identity and now reads its evidence through that identity. Deleted GoalAttemptStore.failure_evidence and migrated all production/test callers; no alias. The read is fenced by attempt, goal and generation. Black-normalized GoalAttemptStore: main before P448 498 lines; merged P448 508; this change 498. GodClassExcess returns 8 -> 0 without changing its threshold.
The compensating order-reissue loop survived in BlockedExecution.enforce_unit_block. Deleted it, its GoalCannotRun forwarding action and the unused captured goal. Blocked and unresolved work are reported, never automatically resumed/reissued. Four tests of that deleted compensation become one report-only preservation case. Added a real native worker/group SIGTERM check against held orders and an UNKNOWN input: stop mid-provider request, assert unchanged Active goal, runnable execution, unchanged orders/input.
Also removed the duplicate open_stream call from the real-turn fixture; OwnedTurn.acquire owns that lifetime.
Evidence
Before inventory: refactor-audit Package covers HEAD/main declarations, inheritance, imports, checks and consumers; mi-owner-ast.log. Required method deletion searched across src/tests; caller migration complete. Patterns: IMPL-12 competing recovery, IDEN-5 restated failure state. Dynamic Python resolution remains outside AST proof.
Verification
104 focused Core cases collected, running under timeout 300 / -n 0 / faulthandler_timeout=60. Final results pending; no installed acceptance claimed. No local ratchets or full suite.
Assumed: