Skip to content

The practice copy is bounded by free disk alone #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trissim merged 1 commit into from
Oct 21, 2026
Merged

The practice copy is bounded by free disk alone #2563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/agent_comms/installer/practice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@ class PracticeMeasurement:
bytes: int
seconds: float

max_bytes = 3 * 1024**3

@classmethod
def of(cls, copy: Path, seconds: float, floor: float) -> PracticeMeasurement:
"""Refuse a copy over its cap or without room for the rehearsal's second copy."""
"""Refuse a copy without room for the rehearsal's second copy above the disk floor. The
free space is what a copy can cost; a fixed byte cap beside it refused a 3.01 GiB bus
with 29 GiB free and stopped install 45."""
size = sum(path.stat().st_size for path in copy.rglob("*") if path.is_file())
if size > cls.max_bytes:
raise UpgradeRefused(f"Practice copy is {size} bytes, over its {cls.max_bytes} cap")
if shutil.disk_usage(copy.parent).free < 2 * size + floor:
raise UpgradeRefused(f"Insufficient free space for rehearsal of {size} copied bytes")
return cls(size, seconds)
Expand Down
Loading