Repository navigation
Chokehold release finds the units it paused - #2561
Merged
Merged
Conversation
ChokeholdAnswer.held walked thread.goal.active(), which is NoGoal for every paused goal, so a quoting answer released nothing and the chokehold held the fleet forever. It reads the thread's goal itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AeUaZjvChAcb6qAd6zPYmw
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChokeholdAnswer.held walked
thread.goal.active(), which is NoGoal for every paused goal. So once the chokehold paused the fleet, a quoting answer released nothing. It now reads the thread goal itself.tests/test_chokehold_release.pychecks that a chokehold-paused unit is held while an owner pause and a running unit are not.The commander found this in its dry run of #2551. It is mine.
Generated by Claude Code